git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup

From
James Denholm <nod.helm@gmail.com>
Date
May 5, 2014, 21:59 UTC
Message-ID
<fbc4c901-9389-48ea-a675-73739a11a647@email.android.com>
In-Reply-To
<20140505214930.GB16971@sigill.intra.peff.net>
On 6 May 2014 07:49:30 GMT+10:00, Jeff King <peff@peff.net> wrote:
Show 20 quoted lines
>On Tue, May 06, 2014 at 07:41:29AM +1000, James Denholm wrote:
>
>> >I do not think BSD-ism matters for "rm", as it works pretty much the
>> >same everywhere. "install", on the other hand, is a bit weirder
>between
>> >systems. So you might want to leave that comment as-is.
>> 
>> True. I might just buff that out when sending the patch to Junio,
>unless
>> protocol dictates otherwise - a reroll for a single comment line
>seems
>> a bit excessive to me at the moment.
>
>I don't think it is that big a deal either way.
>
>It's fine to tweak when you send re-roll the final for Junio. Sometimes
>for trivial fixups like this, Junio can just tweak it as he applies,
>but
>I do not know if he is even paying attention to this thread, so you may
>want to re-post anyway to get his attention.
Sure, sounds good and will do.
>Either way, feel free to add my:
>
>  Reviewed-by: Jeff King <peff@peff.net>
Awesome, thanks again.

Regards, James Denholm.

Previous: Jeff KingNext: Jeff King
Message 10 of 14 in “contrib/subtree/Makefile: Standardisation pass”
  1. 0/5 contrib/subtree/Makefile: Standardisation passJames Denholm, May 3, 2014
  2. 1/5 contrib/subtree/Makefile: scrap unused $(gitdir)James Denholm, May 3, 2014
  3. 2/5 contrib/subtree/Makefile: Use GIT-VERSION-FILEJames Denholm, May 3, 2014
  4. 3/5 contrib/subtree/Makefile: s/libexecdir/gitexecdirJames Denholm, May 3, 2014
  5. 4/5 contrib/subtree/Makefile: Doc-gen rules cleanupJames Denholm, May 3, 2014
  6. 5/5 contrib/subtree/Makefile: clean rule cleanupJames Denholm, May 3, 2014
  7. Jeff KingMay 5, 2014
  8. James DenholmMay 5, 2014
  9. Jeff KingMay 5, 2014
  10. James DenholmMay 5, 2014
  11. Jeff KingMay 5, 2014
  12. James DenholmMay 5, 2014
  13. Jeff KingMay 5, 2014
  14. James DenholmMay 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.