Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass

From: Jeff King <peff@peff.net>
Date: May 5, 2014, 22:01 UTC
Message-ID: <20140505220112.GA17610@sigill.intra.peff.net>
In-Reply-To: <69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com>

[fixed David's address in cc list]

On Tue, May 06, 2014 at 07:54:30AM +1000, James Denholm wrote:

> Given that subtree subtree doesn't really generate a lot of discussion,
> would it be advisable to wrap this up (barring further discussion) and send
> it off to Junio rather than waiting for further community consensus?

I do not know if "lack of discussion" is a good reason to consider something in good shape; oftentimes it is a sign that nobody is interested in the area. We usually rely on "area maintainers" to give an OK to the patches if they are not something that the maintainer himself has an interest in.

However, in this case, you did get review, and I think it is pretty easy to see the patches are good even if one does not care about the particular area. So I think they are fine to pass on and apply.

Note also that patches like this are a great place to get started, as they help build trust in a contributor, who can later help out with area maintenance.

-Peff