Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup

From: Jeff King <peff@peff.net>
Date: May 5, 2014, 05:09 UTC
Message-ID: <20140505050938.GB6569@sigill.intra.peff.net>
In-Reply-To: <1399121375-14727-6-git-send-email-nod.helm@gmail.com>

On Sat, May 03, 2014 at 10:49:35PM +1000, James Denholm wrote:

Show 13 quoted lines

> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index f3834b5..4f96a24 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -11,8 +11,9 @@ man1dir ?= $(mandir)/man1
>  
>  -include ../../GIT-VERSION-FILE
>  
> -# this should be set to a 'standard' bsd-type install program
> -INSTALL ?= install
> +# These should be set to 'standard' bsd-type programs
> +INSTALL  ?= install
> +RM       ?= rm -f

I do not think BSD-ism matters for "rm", as it works pretty much the same everywhere. "install", on the other hand, is a bit weirder between systems. So you might want to leave that comment as-is.

OTOH, we do not even bother with such a comment in the main Makefile.

-Peff