git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass

From
James Denholm <nod.helm@gmail.com>
Date
May 3, 2014, 12:49 UTC
Message-ID
<1399121375-14727-1-git-send-email-nod.helm@gmail.com>

contrib/subtree/Makefile is a shambles in regards to it's consistency with other makefiles, which makes subtree overly painful to include in build scripts.

The main issues are that calls are made to git itself in the build process, and that a subtree-exclusive variable is used for specifying the exec path. Patches 1/5 through 3/5 resolve these.

The "cleanup" fixes (4/5 and 5/5) are based on precedents set by other makefiles across the project.

One problem is foreseen: 3/5 will necessitate that package maintainers who already have git-subtree included in their packages update their build-scripts.

Signed-off-by: James Denholm <nod.helm@gmail.com>
Based-on-patch-by: Dan McGee <dpmcgee@gmail.com>
James Denholm (5):
  contrib/subtree/Makefile: scrap unused $(gitdir)
  contrib/subtree/Makefile: Use GIT-VERSION-FILE
  contrib/subtree/Makefile: s/libexecdir/gitexecdir
  contrib/subtree/Makefile: Doc-gen rules cleanup
  contrib/subtree/Makefile: clean rule cleanup
 contrib/subtree/Makefile | 40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)
-- 
1.9.2
Next: James Denholm
Message 1 of 14 in “contrib/subtree/Makefile: Standardisation pass”
  1. 0/5 contrib/subtree/Makefile: Standardisation passJames Denholm, May 3, 2014
  2. 1/5 contrib/subtree/Makefile: scrap unused $(gitdir)James Denholm, May 3, 2014
  3. 2/5 contrib/subtree/Makefile: Use GIT-VERSION-FILEJames Denholm, May 3, 2014
  4. 3/5 contrib/subtree/Makefile: s/libexecdir/gitexecdirJames Denholm, May 3, 2014
  5. 4/5 contrib/subtree/Makefile: Doc-gen rules cleanupJames Denholm, May 3, 2014
  6. 5/5 contrib/subtree/Makefile: clean rule cleanupJames Denholm, May 3, 2014
  7. Jeff KingMay 5, 2014
  8. James DenholmMay 5, 2014
  9. Jeff KingMay 5, 2014
  10. James DenholmMay 5, 2014
  11. Jeff KingMay 5, 2014
  12. James DenholmMay 5, 2014
  13. Jeff KingMay 5, 2014
  14. James DenholmMay 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.