Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup

From: Jeff King <peff@peff.net>
Date: May 5, 2014, 21:49 UTC
Message-ID: <20140505214930.GB16971@sigill.intra.peff.net>
In-Reply-To: <40d16f4b-440c-4268-bd6a-e7f413d01801@email.android.com>

On Tue, May 06, 2014 at 07:41:29AM +1000, James Denholm wrote:

Show 7 quoted lines

> >I do not think BSD-ism matters for "rm", as it works pretty much the
> >same everywhere. "install", on the other hand, is a bit weirder between
> >systems. So you might want to leave that comment as-is.
> 
> True. I might just buff that out when sending the patch to Junio, unless
> protocol dictates otherwise - a reroll for a single comment line seems
> a bit excessive to me at the moment.

I don't think it is that big a deal either way.

It's fine to tweak when you send re-roll the final for Junio. Sometimes for trivial fixups like this, Junio can just tweak it as he applies, but I do not know if he is even paying attention to this thread, so you may want to re-post anyway to get his attention.

Either way, feel free to add my:

  Reviewed-by: Jeff King <peff@peff.net>

-Peff