Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass

From: Jeff King <peff@peff.net>
Date: May 5, 2014, 05:08 UTC
Message-ID: <20140505050803.GA6569@sigill.intra.peff.net>
In-Reply-To: <1399121375-14727-1-git-send-email-nod.helm@gmail.com>

On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:

Show 6 quoted lines

> The main issues are that calls are made to git itself in the build
> process, and that a subtree-exclusive variable is used for specifying
> the exec path. Patches 1/5 through 3/5 resolve these.
> 
> The "cleanup" fixes (4/5 and 5/5) are based on precedents set by other
> makefiles across the project.

Thanks, these all look sane to me (I do not use subtree, but since it's just about Makefiles, it was pretty easy to review).

> One problem is foreseen: 3/5 will necessitate that package maintainers
> who already have git-subtree included in their packages update their
> build-scripts.

I think that's probably OK. We strive for backwards compatibility in the tool itself, but refactoring Makefiles in contrib/ affects a pretty limited audience.

-Peff