Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup

From: James Denholm <nod.helm@gmail.com>
Date: May 5, 2014, 21:41 UTC
Message-ID: <40d16f4b-440c-4268-bd6a-e7f413d01801@email.android.com>
In-Reply-To: <20140505050938.GB6569@sigill.intra.peff.net>

On 5 May 2014 15:09:39 GMT+10:00, Jeff King <peff@peff.net> wrote:

Show 19 quoted lines

>On Sat, May 03, 2014 at 10:49:35PM +1000, James Denholm wrote:
>
>> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
>> index f3834b5..4f96a24 100644
>> --- a/contrib/subtree/Makefile
>> +++ b/contrib/subtree/Makefile
>> @@ -11,8 +11,9 @@ man1dir ?= $(mandir)/man1
>>  
>>  -include ../../GIT-VERSION-FILE
>>  
>> -# this should be set to a 'standard' bsd-type install program
>> -INSTALL ?= install
>> +# These should be set to 'standard' bsd-type programs
>> +INSTALL  ?= install
>> +RM       ?= rm -f
>
>I do not think BSD-ism matters for "rm", as it works pretty much the
>same everywhere. "install", on the other hand, is a bit weirder between
>systems. So you might want to leave that comment as-is.

True. I might just buff that out when sending the patch to Junio, unless protocol dictates otherwise - a reroll for a single comment line seems a bit excessive to me at the moment.

Regards, James Denholm.