git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup

From
James Denholm <nod.helm@gmail.com>
Date
May 3, 2014, 12:49 UTC
Message-ID
<1399121375-14727-5-git-send-email-nod.helm@gmail.com>
In-Reply-To
<1399121375-14727-4-git-send-email-nod.helm@gmail.com>

git:Documentation/Makefile establishes asciidoc/xmlto calls as being handled through their appropriate variables, Hence, change to bring into congruency with.

Similarly, MANPAGE_XSL exists in git:Documentation/Makefile, while MANPAGE_NORMAL_XSL does not outside contrib/subtree. Hence, replace MANPAGE_NORMAL_XSL with MANPAGE_XSL.

Signed-off-by: James Denholm <nod.helm@gmail.com>
---
 contrib/subtree/Makefile | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
index 579bb51..f3834b5 100644
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -14,8 +14,11 @@ man1dir ?= $(mandir)/man1
 # this should be set to a 'standard' bsd-type install program
 INSTALL ?= install
 
-ASCIIDOC_CONF      = ../../Documentation/asciidoc.conf
-MANPAGE_NORMAL_XSL =  ../../Documentation/manpage-normal.xsl
+ASCIIDOC = asciidoc
+XMLTO    = xmlto
+
+ASCIIDOC_CONF = ../../Documentation/asciidoc.conf
+MANPAGE_XSL   = ../../Documentation/manpage-normal.xsl
 
 GIT_SUBTREE_SH := git-subtree.sh
 GIT_SUBTREE    := git-subtree
@@ -43,14 +46,14 @@ install-man: $(GIT_SUBTREE_DOC)
 	$(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)
 
 $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)
-	xmlto -m $(MANPAGE_NORMAL_XSL)  man $^
+	$(XMLTO) -m $(MANPAGE_XSL) man $^
 
 $(GIT_SUBTREE_XML): $(GIT_SUBTREE_TXT)
-	asciidoc -b docbook -d manpage -f $(ASCIIDOC_CONF) \
+	$(ASCIIDOC) -b docbook -d manpage -f $(ASCIIDOC_CONF) \
 		-agit_version=$(GIT_VERSION) $^
 
 $(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)
-	asciidoc -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \
+	$(ASCIIDOC) -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \
 		-agit_version=$(GIT_VERSION) $^
 
 test:
-- 
1.9.2
Previous: James DenholmNext: James Denholm
Message 5 of 14 in “contrib/subtree/Makefile: Standardisation pass”
  1. 0/5 contrib/subtree/Makefile: Standardisation passJames Denholm, May 3, 2014
  2. 1/5 contrib/subtree/Makefile: scrap unused $(gitdir)James Denholm, May 3, 2014
  3. 2/5 contrib/subtree/Makefile: Use GIT-VERSION-FILEJames Denholm, May 3, 2014
  4. 3/5 contrib/subtree/Makefile: s/libexecdir/gitexecdirJames Denholm, May 3, 2014
  5. 4/5 contrib/subtree/Makefile: Doc-gen rules cleanupJames Denholm, May 3, 2014
  6. 5/5 contrib/subtree/Makefile: clean rule cleanupJames Denholm, May 3, 2014
  7. Jeff KingMay 5, 2014
  8. James DenholmMay 5, 2014
  9. Jeff KingMay 5, 2014
  10. James DenholmMay 5, 2014
  11. Jeff KingMay 5, 2014
  12. James DenholmMay 5, 2014
  13. Jeff KingMay 5, 2014
  14. James DenholmMay 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.