Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()
- From
- Dragan Simic <dsimic@manjaro.org>
- Date
- Jan 18, 2024, 20:50 UTC
- Message-ID
- <dd82bef87fd82f7c4bf7cbff5f873141@manjaro.org>
- In-Reply-To
- <xmqqwms6pf72.fsf@gitster.g>
On 2024-01-18 21:19, Junio C Hamano wrote:
Show 19 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes: >> On 2024-01-18 19:26, Junio C Hamano wrote: >>> Dragan Simic <dsimic@manjaro.org> writes: >>> >>>> Perhaps having both options available could be a good thing. >>>> Though, >>>> adding quite a few knobs may end up confusing the users, so we >>>> should >>>> make sure to document it well. >>> >>> I agree there is a need for documentation, but we are not increasing >>> the number of knobs, are we? >> >> Perhaps there would be one more knob if we end up deciding to >> implement >> support for both approaches, as previously discussed. > > But that would be just one knob (which I personally do not quite see > the need for), not "quite a few knobs" as you said, no?
I'm sorry for being imprecise. Regarding the need for that additional "global" knob, I think it can't hurt. Some people might even find it quite useful, and the good thing is that it wouldn't make the internal logic significantly more complicated.