Re: [PATCH] advice: allow disabling the automatic hint in advise_if_enabled()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2024, 04:56 UTC
Message-ID: <xmqqttnd511n.fsf@gitster.g>
In-Reply-To: <20240113073828.GB657764@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> For a tri-state we often use "-1" for "not specified". That has the nice
> side effect in this case that "if (level)" shows the advice (that works
> because "unspecified" and "explicitly true" both show the advice. And
> then "if (level < 0)" is used for just the hint. But maybe that is too
> clever/fragile.
>
> Of course that means that all of the initializers have to use "-1"
> explicitly. So zero-initialization is sometimes nice, too.

;-)  100% agreed.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.