From: Dragan Simic Date: Thu, 18 Jan 2024 20:50:23 GMT Subject: Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled() Message-ID: In-Reply-To: On 2024-01-18 21:19, Junio C Hamano wrote: > Dragan Simic writes: >> On 2024-01-18 19:26, Junio C Hamano wrote: >>> Dragan Simic writes: >>> >>>> Perhaps having both options available could be a good thing. >>>> Though, >>>> adding quite a few knobs may end up confusing the users, so we >>>> should >>>> make sure to document it well. >>> >>> I agree there is a need for documentation, but we are not increasing >>> the number of knobs, are we? >> >> Perhaps there would be one more knob if we end up deciding to >> implement >> support for both approaches, as previously discussed. > > But that would be just one knob (which I personally do not quite see > the need for), not "quite a few knobs" as you said, no? I'm sorry for being imprecise. Regarding the need for that additional "global" knob, I think it can't hurt. Some people might even find it quite useful, and the good thing is that it wouldn't make the internal logic significantly more complicated.