Re: [PATCH 0/3] allow disabling the automatic hint in advise_if_enabled()

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 9, 2024, 18:28 UTC
Message-ID: <ZZ2QafUf/JxXYZU/@nand.local>
In-Reply-To: <7c68392c-af2f-4999-ae64-63221bf7833a@gmail.com>

On Tue, Jan 09, 2024 at 04:25:32PM +0100, Rubén Justo wrote:

Show 11 quoted lines

> Using advise_if_enabled() to display an advice will automatically
> include instructions on how to disable the advice, along with the main
> advice:
>
> 	hint: use --reapply-cherry-picks to include skipped commits
> 	hint: Disable this message with "git config advice.skippedCherryPicks false"
>
> This may become distracting or "noisy" over time, while the user may
> still want to receive the main advice.
>
> Let's have a switch to allow disabling this automatic advice.

I reviewed this and had a couple of notes, mostly focused on what to call the new configuration option, and if we should be modifying the test-tool helpers to accept arbitrary configuration via command-line options.

I think that we could reasonably drop the first two patches by imitating the existing style of t0018 more closely, but I don't feel all that strongly about it.

So I would probably expect a reroll of this series, but if you disagree with my comments, I would not be sad to see this series merged as-is.

Thanks, Taylor