Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 10, 2024, 16:14 UTC
- Message-ID
- <xmqqo7dtdv3q.fsf@gitster.g>
- In-Reply-To
- <20240110110226.GC16674@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 26 quoted lines
> If I'm reading your patch correctly, this is a single option that > controls the extra line for _all_ advice messages. But I'd have expected > this to be something you'd want to set on a per-message basis. Here's my > thinking. > > The original idea for advice messages was that they might be verbose and > annoying, but if you had one that showed up a lot you'd choose to shut > it up individually. But you wouldn't do so for _all_ messages, because > you might benefit from seeing others (including new ones that get > added). The "Disable this..." part was added later to help you easily > know which config option to tweak. > > The expectation was that you'd fall into one of two categories: > > 1. You don't see the message often enough to care, so you do nothing. > > 2. You do find it annoying, so you disable this instance. > > Your series proposes a third state: > > 3. You find the actual hint useful, but the verbosity of "how to shut > it up" is too much for you. > > That make sense to me, along with being able to partially shut-up a > message. But wouldn't you still need the "how to shut up" hint for > _other_ messages, since it's customized for each situation?
Thanks for saying what I wanted to say in my one of the messages much clearly than I could. The above is exactly why I would be more sympathetic to "advice.foo = (yes/no/always)".