Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()

From: Rubén Justo <rjusto@gmail.com>
Date: Jan 10, 2024, 14:32 UTC
Message-ID: <97fdf6d4-1403-4fe9-b912-a85342a9fa56@gmail.com>
In-Reply-To: <aaf59fc82ef3132ece8e1f70623570a2@manjaro.org>

On 10-ene-2024 15:18:17, Dragan Simic wrote:

> On 2024-01-10 12:02, Jeff King wrote:

Show 6 quoted lines

> Just to chime in and support this behavior of the advice messages.
> Basically, you don't want to have them all disabled at the same time, but to
> have per-message enable/disable granularity.  I'd guess that some of the
> messages are quite usable even to highly experienced users, and encountering
> newly added messages is also very useful.  Thus, having them all disabled
> wouldn't be the best idea.

Totally agree.

This series is about disabling _the part in the advice about how to disable the advice_, but not the proper advice.

Maybe the name ADVICE_ADVICE_OFF has caused confusion.  Sorry if so.