Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()

From: Dragan Simic <dsimic@manjaro.org>
Date: Jan 10, 2024, 14:44 UTC
Message-ID: <a97b03a305a7b8b95341b63af1de0271@manjaro.org>
In-Reply-To: <97fdf6d4-1403-4fe9-b912-a85342a9fa56@gmail.com>

On 2024-01-10 15:32, Rubén Justo wrote:

Show 20 quoted lines

> On 10-ene-2024 15:18:17, Dragan Simic wrote:
>> On 2024-01-10 12:02, Jeff King wrote:
> 
>> Just to chime in and support this behavior of the advice messages.
>> Basically, you don't want to have them all disabled at the same time, 
>> but to
>> have per-message enable/disable granularity.  I'd guess that some of 
>> the
>> messages are quite usable even to highly experienced users, and 
>> encountering
>> newly added messages is also very useful.  Thus, having them all 
>> disabled
>> wouldn't be the best idea.
> 
> Totally agree.
> 
> This series is about disabling _the part in the advice about how to
> disable the advice_, but not the proper advice.
> 
> Maybe the name ADVICE_ADVICE_OFF has caused confusion.  Sorry if so.

No worries. Regarding disabling the advices for disabling the advice messages, maybe it would be better to have only one configuration knob for that purpose, e.g. "core.verboseAdvice", as a boolean knob. That way, fishing for the right knob for some advice message wouldn't turn itself into an issue, and the users would be able to turn the additional "advices about advices" on and off easily, to be able to see what knobs actually turn off the advice messages that have become annoying enough to them.