Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2024, 19:57 UTC
Message-ID: <xmqqjzoigtzg.fsf@gitster.g>
In-Reply-To: <ZZ2QGYBBmK8cSYBD@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 10 quoted lines

> Looking at this test, I wonder why we don't imitate the existing style
> of:
>
>     test_config advice.adviceOff false &&
>     test-tool advise "This is a piece of advice" 2>actual &&
>     test_cmp expect actual
>
> instead of teaching the test-tool helpers how to interpret `-c`
> arguments. Doing so would allow us to drop the first couple of patches
> in this series and simplify things a bit.

Thanks for a dose of sanity. I too got a bit too excited by a shiny new toy ;-) Reusing the existing mechanism does make sense.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.