git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 1/2] list_objects_filter_options: introduce 'list_object_filter_config_name'

From
Taylor Blau <me@ttaylorr.com>
Date
Mar 17, 2020, 20:39 UTC
Message-ID
<c75806d011b04f2ad7efbbec01613a2d0b1f570b.1584477196.git.me@ttaylorr.com>
In-Reply-To
<cover.1584477196.git.me@ttaylorr.com>
In a subsequent commit, we will add configuration options that are
specific to each kind of object filter, in which case it is handy to
have a function that translates between 'enum
list_objects_filter_choice' and an appropriate configuration-friendly
string.
---
 list-objects-filter-options.c | 25 +++++++++++++++++++++++++
 list-objects-filter-options.h |  6 ++++++
 2 files changed, 31 insertions(+)
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 256bcfbdfe..6b6aa0b3ec 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -15,6 +15,31 @@ static int parse_combine_filter(
 	const char *arg,
 	struct strbuf *errbuf);
 
+const char *list_object_filter_config_name(enum list_objects_filter_choice c)
+{
+	switch (c) {
+	case LOFC_BLOB_NONE:
+		return "blob:none";
+	case LOFC_BLOB_LIMIT:
+		return "blob:limit";
+	case LOFC_TREE_DEPTH:
+		return "tree:depth";
+	case LOFC_SPARSE_OID:
+		return "sparse:oid";
+	case LOFC_COMBINE:
+		return "combine";
+	case LOFC_DISABLED:
+	case LOFC__COUNT:
+		/*
+		 * Include these to catch all enumerated values, but
+		 * break to treat them as a bug. Any new values of this
+		 * enum will cause a compiler error, as desired.
+		 */
+		break;
+	}
+	BUG("list_object_filter_choice_name: invalid argument '%d'", c);
+}
+
 /*
  * Parse value of the argument to the "filter" keyword.
  * On the command line this looks like:
diff --git a/list-objects-filter-options.h b/list-objects-filter-options.h
index 2ffb39222c..e5259e4ac6 100644
--- a/list-objects-filter-options.h
+++ b/list-objects-filter-options.h
@@ -17,6 +17,12 @@ enum list_objects_filter_choice {
 	LOFC__COUNT /* must be last */
 };
 
+/*
+ * Returns a configuration key suitable for describing the given object filter,
+ * e.g.: "blob:none", "combine", etc.
+ */
+const char *list_object_filter_config_name(enum list_objects_filter_choice c);
+
 struct list_objects_filter_options {
 	/*
 	 * 'filter_spec' is the raw argument value given on the command line
-- 
2.26.0.rc2.2.g888d9484cf
Previous: Taylor BlauNext: Eric Sunshine
Message 55 of 106 in “Notes from Git Contributor Summit, Los Angeles (April 5, 2020)”
  1. James RamsayMar 12, 2020
  2. 1/17 ReftableJames Ramsay, Mar 12, 2020
  3. 2/17 Hooks in the futureJames Ramsay, Mar 12, 2020
  4. Emily ShafferMar 12, 2020
  5. Junio C HamanoMar 13, 2020
  6. Emily ShafferApr 7, 2020
  7. Emily ShafferApr 7, 2020
  8. Junio C HamanoApr 8, 2020
  9. Emily ShafferApr 8, 2020
  10. Jeff KingApr 10, 2020
  11. Emily ShafferApr 13, 2020
  12. Jeff KingApr 13, 2020
  13. 0/2 configuration-based hook management (was: [TOPIC 2/17] Hooks in the future)Emily Shaffer, Apr 14, 2020
  14. 1/2 hook: scaffolding for git-hook subcommandEmily Shaffer, Apr 14, 2020
  15. 2/2 hook: add --list modeEmily Shaffer, Apr 14, 2020
  16. Phillip WoodApr 14, 2020
  17. Emily ShafferApr 14, 2020
  18. Jeff KingApr 14, 2020
  19. Phillip WoodApr 15, 2020
  20. Josh SteadmonApr 14, 2020
  21. Phillip WoodApr 15, 2020
  22. Jeff KingApr 14, 2020
  23. Phillip WoodApr 15, 2020
  24. Junio C HamanoApr 15, 2020
  25. Emily ShafferApr 15, 2020
  26. Junio C HamanoApr 15, 2020
  27. Jonathan NiederApr 15, 2020
  28. Emily ShafferApr 15, 2020
  29. doc: propose hooks managed by the configEmily Shaffer, Apr 20, 2020
  30. Emily ShafferApr 21, 2020
  31. Junio C HamanoApr 21, 2020
  32. Emily ShafferApr 24, 2020
  33. brian m. carlsonApr 25, 2020
  34. Emily ShafferMay 6, 2020
  35. brian m. carlsonMay 6, 2020
  36. Emily ShafferMay 19, 2020
  37. Jeff KingApr 15, 2020
  38. Emily ShafferApr 15, 2020
  39. Jeff KingApr 15, 2020
  40. 3/17 ObliterateJames Ramsay, Mar 12, 2020
  41. Konstantin RyabitsevMar 12, 2020
  42. Damien RobertMar 15, 2020
  43. Konstantin TokarevMar 16, 2020
  44. Damien RobertMar 26, 2020
  45. Elijah NewrenMar 16, 2020
  46. Damien RobertMar 26, 2020
  47. Phillip SusiMar 16, 2020
  48. Damien RobertMar 26, 2020
  49. Philip OakleyMar 16, 2020
  50. nbelakovski@gmail.comMay 16, 2020
  51. 4/17 Sparse checkoutJames Ramsay, Mar 12, 2020
  52. 5/17 Partial CloneJames Ramsay, Mar 12, 2020
  53. Allowing only blob filtering was: [TOPIC 5/17] Partial CloneChristian Couder, Mar 17, 2020
  54. 0/2 upload-pack.c: limit allowed filter choicesTaylor Blau, Mar 17, 2020
  55. 1/2 list_objects_filter_options: introduce 'list_object_filter_config_name'Taylor Blau, Mar 17, 2020
  56. Eric SunshineMar 17, 2020
  57. Jeff KingMar 18, 2020
  58. Junio C HamanoMar 18, 2020
  59. Eric SunshineMar 18, 2020
  60. Jeff KingMar 19, 2020
  61. Taylor BlauMar 18, 2020
  62. 2/2 upload-pack.c: allow banning certain object filter(s)Taylor Blau, Mar 17, 2020
  63. Eric SunshineMar 17, 2020
  64. Taylor BlauMar 18, 2020
  65. Philip OakleyMar 18, 2020
  66. Taylor BlauMar 18, 2020
  67. Jeff KingMar 18, 2020
  68. Re*: [RFC PATCH 0/2] upload-pack.c: limit allowed filter choicesJunio C Hamano, Mar 18, 2020
  69. Jeff KingMar 19, 2020
  70. Taylor BlauMar 18, 2020
  71. Junio C HamanoMar 18, 2020
  72. Jeff KingMar 19, 2020
  73. Jeff KingMar 19, 2020
  74. Christian CouderApr 17, 2020
  75. Taylor BlauApr 17, 2020
  76. Jeff KingApr 17, 2020
  77. Christian CouderApr 21, 2020
  78. Taylor BlauApr 22, 2020
  79. Taylor BlauApr 22, 2020
  80. Christian CouderApr 21, 2020
  81. 6/17 GC strategiesJames Ramsay, Mar 12, 2020
  82. 7/17 Background operations/maintenanceJames Ramsay, Mar 12, 2020
  83. 8/17 Push performanceJames Ramsay, Mar 12, 2020
  84. 9/17 Obsolescence markers and evolveJames Ramsay, Mar 12, 2020
  85. Noam SoloveichikMay 9, 2020
  86. Jeff KingMay 15, 2020
  87. 10/17 Expel ‘git shell’?James Ramsay, Mar 12, 2020
  88. 11/17 GPL enforcementJames Ramsay, Mar 12, 2020
  89. 12/17 Test harness improvementsJames Ramsay, Mar 12, 2020
  90. 13/17 Cross implementation test suiteJames Ramsay, Mar 12, 2020
  91. 14/17 Aspects of merge-ort: cool, or crimes against humanity?James Ramsay, Mar 12, 2020
  92. 15/17 Reachability checksJames Ramsay, Mar 12, 2020
  93. 16/17 “I want a reviewer”James Ramsay, Mar 12, 2020
  94. Emily ShafferMar 12, 2020
  95. Konstantin RyabitsevMar 12, 2020
  96. Jonathan NiederMar 12, 2020
  97. Konstantin RyabitsevMar 12, 2020
  98. Philippe BlainMar 17, 2020
  99. Eric WongMar 13, 2020
  100. Jeff KingMar 14, 2020
  101. inbox indexing wishlist [was: [TOPIC 16/17] “I want a reviewer”]Eric Wong, Mar 15, 2020
  102. 17/17 SecurityJames Ramsay, Mar 12, 2020
  103. Derrick StoleeMar 12, 2020
  104. Jeff KingMar 13, 2020
  105. Jakub NarebskiMar 15, 2020
  106. Jeff KingMar 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.