Re: [RFC PATCH 0/2] upload-pack.c: limit allowed filter choices

From: Jeff King <peff@peff.net>
Date: Mar 19, 2020, 17:09 UTC
Message-ID: <20200319170954.GB4075823@coredump.intra.peff.net>
In-Reply-To: <20200318212818.GE31397@syl.local>

On Wed, Mar 18, 2020 at 03:28:18PM -0600, Taylor Blau wrote:

> I wonder. A multi-valued 'uploadpack.filter.allow' *might* solve some
> problems, but the more I turn it over in my head, the more that I think
> that it's creating more headaches for us than it's removing.

IMHO we should avoid multi-valued keys when there's not a compelling reason. There are a lot of corner cases they introduce (e.g., there's no standard way to override them rather than adding to the list).

Show 10 quoted lines

> Another thing we could do is just simply use a different character. It
> may be a little odd, but it keeps the filter-related variables in their
> own sub-section, allowing us to add more configuration sub-variables in
> the future. I guess that calling it something like:
> 
>   $ git config uploadpack.filter@blob:none.allow <true|false>
> 
> is a little strange (i.e., why '@' over '#'? There's certainly no
> precedent here that I can think of...), but maybe it is slightly
> less-weird than a pseudo-four-level key.

I guess it's subjective, but the "@" just feels odd because it's associated with so many other meanings. Likewise "#".

-Peff