Re: [PATCH/RFC/GSoC 09/17] rebase-common: implement cache_has_unstaged_changes()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 15, 2016, 11:51 UTC
Message-ID: <alpine.DEB.2.20.1603151249570.4690@virtualbox>
In-Reply-To: <xmqqoaag9177.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 14 Mar 2016, Junio C Hamano wrote:

Show 5 quoted lines

> If the [has_uncommitted_changes()] function will be made a public helper
> that may be called by anybody, a possible error reporting mechanism
> would be to give a list of modified paths to the caller that asks them,
> and have the caller apply its own "prefix" processing to make them
> relative.

But the point of the has_uncommitted_changes() is to figure out as fast as possible whether there are uncommitted changes, not the exact list. In fact, we want to return with a "yes" as soon as we encounter the first uncommitted change.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.