Re: [PATCH/RFC/GSoC 01/17] perf: introduce performance tests for git-rebase

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 16, 2016, 07:58 UTC
Message-ID: <alpine.DEB.2.20.1603160855390.4690@virtualbox>
In-Reply-To: <1457779597-6918-2-git-send-email-pyokagan@gmail.com>

Hi Paul,

On Sat, 12 Mar 2016, Paul Tan wrote:

Show 14 quoted lines

> diff --git a/t/perf/p3404-rebase-interactive.sh b/t/perf/p3404-rebase-interactive.sh
> new file mode 100755
> index 0000000..aaca105
> --- /dev/null
> +++ b/t/perf/p3404-rebase-interactive.sh
> @@ -0,0 +1,26 @@
>
> [...]
>
> +test_perf 'rebase -i --onto master^' '
> +	git checkout perf-topic-branch &&
> +	git reset --hard perf-topic-branch-initial &&
> +	GIT_SEQUENCE_EDITOR=: git rebase -i --onto master^ master
> +'

This measures the performance of checkout && reset && rebase -i. Maybe we should only test rebase -i?

Also, I would strongly recommend an extra test_commit after reset; Otherwise you would only test the logic that verifies that it can simply fast-forward instead of cherry-picking.

Ciao, Dscho