Re: [PATCH/RFC/GSoC 00/17] A barebones git-rebase in C

From: Stefan Beller <sbeller@google.com>
Date: Mar 14, 2016, 17:32 UTC
Message-ID: <CAGZ79kZw+y6G_Y+ZkRLK6a4CG5qycM_MJFRQoQccyq596L56kw@mail.gmail.com>
In-Reply-To: <CACsJy8BmiqFJ1tN6-uAWqXMUyvGRdWP2DVfgwE56Y1K9KHCsfQ@mail.gmail.com>

On Mon, Mar 14, 2016 at 5:15 AM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 21 quoted lines

> On Sat, Mar 12, 2016 at 5:46 PM, Paul Tan <pyokagan@gmail.com> wrote:
>> So, we have around a 1.4x-1.8x speedup for Linux users, and a 1.7x-13x speedup
>> for Windows users. The annoying long delay before the interactive editor is
>> launched on Windows is gotten rid of, which I'm very happy about :-)
>
> Nice numbers :-) Sorry I can't look at your patches yet. Just a very
> minor comment from diffstat..
>
>>  rebase-am.c                        | 110 +++++++++++
>>  rebase-am.h                        |  22 +++
>>  rebase-common.c                    | 220 ++++++++++++++++++++++
>>  rebase-common.h                    |  48 +++++
>>  rebase-interactive.c               | 375 +++++++++++++++++++++++++++++++++++++
>>  rebase-interactive.h               |  33 ++++
>>  rebase-merge.c                     | 256 +++++++++++++++++++++++++
>>  rebase-merge.h                     |  28 +++
>>  rebase-todo.c                      | 251 +++++++++++++++++++++++++
>>  rebase-todo.h                      |  55 ++++++
>
> topdir is already very crowded. Maybe you could move all these files
> to "rebase" subdir.

or builtin/ (or even builtin/rebase) ?

I thought the toplevel being crowded is by design such that it doesn't feel like a java project where each file has 5 directories for itself.

I'll look at the series later today.

Stefan

> --
> Duy