Re: [PATCH/RFC/GSoC 00/17] A barebones git-rebase in C
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 14, 2016, 20:44 UTC
- Message-ID
- <alpine.DEB.2.20.1603142142260.4690@virtualbox>
- In-Reply-To
- <CACsJy8BmiqFJ1tN6-uAWqXMUyvGRdWP2DVfgwE56Y1K9KHCsfQ@mail.gmail.com>
Hi Duy,
On Mon, 14 Mar 2016, Duy Nguyen wrote:
Show 15 quoted lines
> On Sat, Mar 12, 2016 at 5:46 PM, Paul Tan <pyokagan@gmail.com> wrote: > > > rebase-am.c | 110 +++++++++++ > > rebase-am.h | 22 +++ > > rebase-common.c | 220 ++++++++++++++++++++++ > > rebase-common.h | 48 +++++ > > rebase-interactive.c | 375 +++++++++++++++++++++++++++++++++++++ > > rebase-interactive.h | 33 ++++ > > rebase-merge.c | 256 +++++++++++++++++++++++++ > > rebase-merge.h | 28 +++ > > rebase-todo.c | 251 +++++++++++++++++++++++++ > > rebase-todo.h | 55 ++++++ > > topdir is already very crowded. Maybe you could move all these files > to "rebase" subdir.
Yes, I had mentioned a couple times that my preference would be to introduce a rebase--helper builtin and move functionality into it one by one, which is incidentally exactly what I already did in my 'interactive-rebase' branch. It still has a couple of very rough edges, but I could not work on it today (because v2.7.3 surprised me and shuffled my tasks around, and then I hunted two bugs the entire day and have to continue tomorrow).
Paul, may I ask you to concentrate on the parts that are *not* the interactive rebase?
Ciao, Johannes