From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 15 Mar 2016 11:51:29 GMT
Subject: Re: [PATCH/RFC/GSoC 09/17] rebase-common: implement cache_has_unstaged_changes()
Message-ID: <alpine.DEB.2.20.1603151249570.4690@virtualbox>
In-Reply-To: <xmqqoaag9177.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 14 Mar 2016, Junio C Hamano wrote:

> If the [has_uncommitted_changes()] function will be made a public helper
> that may be called by anybody, a possible error reporting mechanism
> would be to give a list of modified paths to the caller that asks them,
> and have the caller apply its own "prefix" processing to make them
> relative.

But the point of the has_uncommitted_changes() is to figure out as fast as
possible whether there are uncommitted changes, not the exact list. In
fact, we want to return with a "yes" as soon as we encounter the first
uncommitted change.

Ciao,
Dscho