Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 15, 2016, 07:00 UTC
Message-ID: <alpine.DEB.2.20.1603150755450.4690@virtualbox>
In-Reply-To: <1457779597-6918-17-git-send-email-pyokagan@gmail.com>

Hi Paul,

On Sat, 12 Mar 2016, Paul Tan wrote:

> Signed-off-by: Paul Tan <pyokagan@gmail.com>

This commit message is very short.

> ---
>  cache.h  |  1 +

No need to clutter cache.h with a function that is only to be used by the sequencer. IOW let's make this static in sequencer.c.

I would also prefer pairing this short function with the change that actually uses it (in my topic branches, I like to compile with -Werror, which would result in a failure due to an unused function), in the same patch.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.