Re: [PATCH/RFC/GSoC 00/17] A barebones git-rebase in C

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 14, 2016, 12:15 UTC
Message-ID: <CACsJy8BmiqFJ1tN6-uAWqXMUyvGRdWP2DVfgwE56Y1K9KHCsfQ@mail.gmail.com>
In-Reply-To: <1457779597-6918-1-git-send-email-pyokagan@gmail.com>

On Sat, Mar 12, 2016 at 5:46 PM, Paul Tan <pyokagan@gmail.com> wrote:

> So, we have around a 1.4x-1.8x speedup for Linux users, and a 1.7x-13x speedup
> for Windows users. The annoying long delay before the interactive editor is
> launched on Windows is gotten rid of, which I'm very happy about :-)

Nice numbers :-) Sorry I can't look at your patches yet. Just a very minor comment from diffstat..

Show 10 quoted lines

>  rebase-am.c                        | 110 +++++++++++
>  rebase-am.h                        |  22 +++
>  rebase-common.c                    | 220 ++++++++++++++++++++++
>  rebase-common.h                    |  48 +++++
>  rebase-interactive.c               | 375 +++++++++++++++++++++++++++++++++++++
>  rebase-interactive.h               |  33 ++++
>  rebase-merge.c                     | 256 +++++++++++++++++++++++++
>  rebase-merge.h                     |  28 +++
>  rebase-todo.c                      | 251 +++++++++++++++++++++++++
>  rebase-todo.h                      |  55 ++++++

topdir is already very crowded. Maybe you could move all these files to "rebase" subdir.

-- 
Duy