Re: [PATCH v2 4/5] t3301: use test_must_fail instead of !

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2009, 11:53 UTC
Message-ID: <alpine.DEB.1.00.0902181251160.6274@intel-tinevez-2-302>
In-Reply-To: <20090218101615.GA23035@coredump.intra.peff.net>

Hi,

On Wed, 18 Feb 2009, Jeff King wrote:

Show 12 quoted lines

> On Wed, Feb 18, 2009 at 11:14:10AM +0100, Johannes Schindelin wrote:
> 
> > > I can now get as far as t3404, which seems to have problems due to
> > > rebase-interactive using parentheses, "-a", and "-o" with "test".
> > 
> > The parentheses will be fixed soon, but "-a" and "-o" really are 
> > necessary.
> 
> Really? Are they not easily replaced with
> 
> -test cond1 -a cond2 -o cond3
> +test cond1 && test cond2 || test cond3

...which is substantially harder to read.

> ? The trickier part is the grouping, but that is what the parentheses 
> are doing.

I got rid of that code about two weeks ago.

The upcoming rebase -i -p series is unfortunately not in a good shape at the moment; intermediate stages fail the tests, so I will have to clean up a bit.

But at the moment, real world is taking my time, reducing my Git time budget substantially. On the positive side (well, half of it), I fiddle with msysGit these days, as have to use Windows again.

Ciao, Dscho