Re: [PATCH 3/4] t3301: fix confusing test for valid notes ref

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 14, 2009, 19:32 UTC
Message-ID: <alpine.DEB.1.00.0902142029420.10279@pacific.mpi-cbg.de>
In-Reply-To: <21cefcfb71849535430c75575a9decf1f9fe9c06.1234638466.git.trast@student.ethz.ch>

Hi,

On Sat, 14 Feb 2009, Thomas Rast wrote:

> The test used single quotes in the test code, but also single quotes
> to wrap the entire test snippet, thus effectively skipping _out_ of
> quoted mode.  Since it doesn't matter here, just drop the quotes to
> cause less confusion.

ACK.

> Also, the test passed a MSG variable to 'git notes show', but that
> never calls an editor.

That was actually what I tried to test by passing MSG=2... So I'd like to keep it.

> As an aside, is there a specific reason why all the negative tests use 
> '! VAR=foo bar' instead of 'VAR=foo test_must_fail bar'?  I thought the 
> latter was preferred to catch segfaults.

I guess that back then when I wrote the first version of notes (which I hoped Johan Herland would take custody of), test_must_fail either did not exist or was too new for me to have picked up yet.

Ciao, Dscho