Re: [PATCH] test suite: correct export var=val usage

From: Wincent Colaiuta <win@wincent.com>
Date: Feb 18, 2009, 16:56 UTC
Message-ID: <F21AE3A2-480B-4311-81E7-32B75B49A356@wincent.com>
In-Reply-To: <76718490902180529w7520ba64kb7d0d6b284b406bd@mail.gmail.com>

El 18/2/2009, a las 14:29, Jay Soffian escribió:

Show 18 quoted lines

> On Wed, Feb 18, 2009 at 8:19 AM, Jay Soffian <jaysoffian@gmail.com>  
> wrote:
>> On Wed, Feb 18, 2009 at 5:06 AM, Wincent Colaiuta <win@wincent.com>  
>> wrote:
>>> Perhaps my eyes are playing tricks on me but I see the original  
>>> version
>>> setting MSG to an empty string and exporting it, and your version  
>>> setting
>>> MSG to "1" and exporting it. So which one is wrong? The original  
>>> or yours?
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/109897/focus=110462
>
> Rather, http://thread.gmane.org/gmane.comp.version-control.git/109897/focus=110457
>
> (Cursed frame interface.)
>
> (The original is wrong.)

I'm definitely blind then, or perhaps I didn't explain myself. At least, I saw nothing in the message you linked that answers my question. Let me try again.

- Prior to your patch, in the two hunks I quoted we set MSG to an  
empty string and exported it

- After your patch, the hunks now set MSG to "1" (not the same string)  
and export it

In other words, you not only changed the _style_ from "assign and export in a single step" to "assign and then export as two separate steps"; you also changed _what_ gets exported in two of those hunks.

So my question really was, was this intended?

Cheers, Wincent