git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/5] t3301: use test_must_fail instead of !

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2009, 22:20 UTC
Message-ID
<7vr61w3dug.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<tJ6pp2ZnBjKVBLynGfYewBaGmSehbwZNLOShEvpXmtkD3IMXRugEKg@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Notice the 'export' lines.  Comparing it to Thomas's v2 5/5 patch, it
> looks like the first line which sets the variables is correct and the
> export line should just be 'export MSG GIT_NOTES_REF' in both tests.
Thanks for catching my late-night typos.

Some shells do not like "export var=val", and the right way to write these is to do an usual assignment and then export just variable names.

We need to fix the following:

$ git grep -n -e 'export .*=' --and --not -e '-export' pu -- t/ pu:t/t3301-notes.sh:42: export MSG= GIT_NOTES_REF=refs/heads/bogus && pu:t/t3301-notes.sh:48: export MSG= GIT_NOTES_REF=refs/heads/bogus && pu:t/t3302-notes-index-expensive.sh:32: export GIT_INDEX_FILE=.git/temp; pu:t/t3302-notes-index-expensive.sh:66: export GIT_NOTES_REF=non-existing pu:t/t9301-fast-export.sh:188:export GIT_AUTHOR_NAME='A U Thor' pu:t/t9301-fast-export.sh:189:export GIT_COMMITTER_NAME='C O Mitter' pu:t/test-lib.sh:101: export GIT_TEST_LONG=t; shift ;;

Previous: Brandon CaseyNext: Jay Soffian
Message 33 of 47 in “notes: only clean up message file when editing”
  1. 1/4 notes: only clean up message file when editingThomas Rast, Feb 14, 2009
  2. 2/4 notes: use GIT_EDITOR and core.editor over VISUAL/EDITORThomas Rast, Feb 14, 2009
  3. Johannes SchindelinFeb 14, 2009
  4. 3/4 t3301: fix confusing test for valid notes refThomas Rast, Feb 14, 2009
  5. Johannes SchindelinFeb 14, 2009
  6. 4/4 notes: refuse to edit notes outside refs/notes/Thomas Rast, Feb 14, 2009
  7. Johannes SchindelinFeb 14, 2009
  8. Thomas RastFeb 14, 2009
  9. 1/5 notes: only clean up message file when editingThomas Rast, Feb 14, 2009
  10. Junio C HamanoFeb 15, 2009
  11. 2/5 notes: use GIT_EDITOR and core.editor over VISUAL/EDITORThomas Rast, Feb 14, 2009
  12. 3/5 t3301: fix confusing quoting in test for valid notes refThomas Rast, Feb 14, 2009
  13. 4/5 t3301: use test_must_fail instead of !Thomas Rast, Feb 14, 2009
  14. Johannes SchindelinFeb 14, 2009
  15. Junio C HamanoFeb 15, 2009
  16. Thomas RastFeb 15, 2009
  17. Jeff KingFeb 15, 2009
  18. Thomas RastFeb 15, 2009
  19. Mike RalphsonFeb 17, 2009
  20. Jeff KingFeb 17, 2009
  21. Mike RalphsonFeb 17, 2009
  22. Jeff KingFeb 17, 2009
  23. Jeff KingFeb 18, 2009
  24. Johannes SchindelinFeb 18, 2009
  25. Jeff KingFeb 18, 2009
  26. Johannes SchindelinFeb 18, 2009
  27. Jeff KingFeb 19, 2009
  28. Johannes SchindelinFeb 19, 2009
  29. Jeff KingFeb 19, 2009
  30. Thomas RastFeb 17, 2009
  31. Thomas RastFeb 17, 2009
  32. Brandon CaseyFeb 17, 2009
  33. Junio C HamanoFeb 17, 2009
  34. test suite: correct export var=val usageJay Soffian, Feb 17, 2009
  35. Johannes SchindelinFeb 17, 2009
  36. Jay SoffianFeb 18, 2009
  37. test suite: correct export var=val usageJay Soffian, Feb 17, 2009
  38. test suite: correct export var=val usageJay Soffian, Feb 17, 2009
  39. Wincent ColaiutaFeb 18, 2009
  40. Jay SoffianFeb 18, 2009
  41. Jay SoffianFeb 18, 2009
  42. Johannes SchindelinFeb 18, 2009
  43. Wincent ColaiutaFeb 18, 2009
  44. Thomas RastFeb 18, 2009
  45. test suite: correct export var=val usageJay Soffian, Feb 18, 2009
  46. 5/5 notes: refuse to edit notes outside refs/notes/Thomas Rast, Feb 14, 2009
  47. Johannes SchindelinFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.