Re: [PATCH v2 4/5] t3301: use test_must_fail instead of !

From: Jeff King <peff@peff.net>
Date: Feb 19, 2009, 00:37 UTC
Message-ID: <20090219003727.GA25808@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0902181251160.6274@intel-tinevez-2-302>

On Wed, Feb 18, 2009 at 12:53:37PM +0100, Johannes Schindelin wrote:

Show 6 quoted lines

> > Really? Are they not easily replaced with
> > 
> > -test cond1 -a cond2 -o cond3
> > +test cond1 && test cond2 || test cond3
> 
> ...which is substantially harder to read.

I don't agree that it is harder to read, but that is beside the point. What is important is whether or not the construct is portable enough to meet git's standards.

"-a" and "-o" are XSI extensions to POSIX, which is usually a sign that there may be problems. However, besides posh (which at this point I think can be considered a compliance-testing shell and not an actual shell in use), I haven't heard of problems in practice. Even FreeBSD's ash derivative supports it (along with parentheses).

So I don't think it needs to be changed (which is what I said in my original message). But I also think saying "-a and -o are necessary" is not true; they can be replaced if it turns out to be a problem.

-Peff