[PATCH 3/4] t3301: fix confusing test for valid notes ref
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Feb 14, 2009, 19:15 UTC
- Message-ID
- <21cefcfb71849535430c75575a9decf1f9fe9c06.1234638466.git.trast@student.ethz.ch>
- In-Reply-To
- <b36bbe2f7f0ede6a2caa47190ada868dd4c0099c.1234638466.git.trast@student.ethz.ch>
The test used single quotes in the test code, but also single quotes to wrap the entire test snippet, thus effectively skipping _out_ of quoted mode. Since it doesn't matter here, just drop the quotes to cause less confusion.
Also, the test passed a MSG variable to 'git notes show', but that never calls an editor.
Signed-off-by: Thomas Rast <trast@student.ethz.ch> ---
As an aside, is there a specific reason why all the negative tests use '! VAR=foo bar' instead of 'VAR=foo test_must_fail bar'? I thought the latter was preferred to catch segfaults.
t/t3301-notes.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh index ff4ea05..b99271e 100755 --- a/t/t3301-notes.sh +++ b/t/t3301-notes.sh @@ -31,8 +31,8 @@ test_expect_success setup ' ' test_expect_success 'need valid notes ref' ' - ! MSG=1 GIT_NOTES_REF='/' git notes edit && - ! MSG=2 GIT_NOTES_REF='/' git notes show + ! MSG=1 GIT_NOTES_REF=/ git notes edit && + ! GIT_NOTES_REF=/ git notes show ' # 1 indicates caught gracefully by die, 128 means git-show barked
-- 1.6.2.rc0.288.g6852b