Re: [PATCH] test suite: correct export var=val usage

From: Thomas Rast <trast@student.ethz.ch>
Date: Feb 18, 2009, 17:05 UTC
Message-ID: <200902181805.44145.trast@student.ethz.ch>
In-Reply-To: <F21AE3A2-480B-4311-81E7-32B75B49A356@wincent.com>

Wincent Colaiuta wrote:

Show 13 quoted lines

> I'm definitely blind then, or perhaps I didn't explain myself. At  
> least, I saw nothing in the message you linked that answers my  
> question. Let me try again.
> 
> - Prior to your patch, in the two hunks I quoted we set MSG to an  
> empty string and exported it
> 
> - After your patch, the hunks now set MSG to "1" (not the same string)  
> and export it
> 
> In other words, you not only changed the _style_ from "assign and  
> export in a single step" to "assign and then export as two separate  
> steps"; you also changed _what_ gets exported in two of those hunks.

Actually the original version was

  http://article.gmane.org/gmane.comp.version-control.git/109920

which was subsequently fixed by Junio to not use a single-shot export. Then Brandon noticed that during the fix-up, the export line suddenly started exporting values itself, and different ones at that.

So while Jay's patch indeed changes the semantics, the net result is what was intended all along, except it's now (hopefully) compatible with more shells.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch