Re: [PATCH v2 00/18] Introduce rust: In xdiff
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 22, 2025, 13:01 UTC
- Message-ID
- <aNFIwFD6E6Lngy5M@pks.im>
- In-Reply-To
- <xmqqy0qcae6z.fsf@gitster.g>
On Wed, Sep 17, 2025 at 03:48:04PM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Elijah Newren <newren@gmail.com> writes: > > > So, how to move forward? > > > > A) Modify Patrick's series to just take patch 7 of his v5. Patrick > > did say that the roadmap was "the more important discussion compared > > to the technical discussion", and merging that patch would achieve his > > goal of getting an initial roadmap. Then Ezekiel could grab other > > pieces from Patrick's series (e.g. the help and varint stuff) and > > incorporate it into an "introduce rust" series.[*] > > > > B) Merge Patrick's series and tell Ezekiel to rebase, while noting to > > Ezekiel that the roadmap is the important bit from Patrick's series[*] > > and he can suggest changes to any of the other bits. > > > > C) Create a consolidated "introduce Rust" series with bits of both -- > > what I think Ezekiel was trying to do with this series. > > Ah, I didn't even realize C was what this series was trying to do. > > I do not have particular preference between A and B, but I thought A > was closer to what was being done with this series, and as long as > Ezekiel and Patrick can join forces that way, it would be perfect.
I personally think either (A) or (B) would be good choices. I would slightly lean towards (B) just so that we have something that we can already play around with while building the next steps.
By the way: I'm also happy to change attribution of some of the patches in my patch series to mention Ezekiel as author. I don't care much who is listed for the initial patches that introduce Rust, but would retain my own authorship for the "varint" and "BreakingChanges" commits.
Patrick