Re: [PATCH v2 03/18] make: merge xdiff lib into libgit.a

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 19, 2025, 19:54 UTC
Message-ID: <CAH=ZcbBsE3AwoE2t=recg9kwtq8y0tXECRtU9YnbH0WVWZdCCA@mail.gmail.com>
In-Reply-To: <CAPig+cTDUM5nVbBF5L3k+Gr5xYxXdH2ungVvkQ9QVbZCqMsLHg@mail.gmail.com>

On Wed, Sep 17, 2025 at 1:46 AM Eric Sunshine <sunshine@sunshineco.com> wrote:

> Please extend the commit message to explain why this change is desirable.

This commit continues the effort of making the Rust compiler link against libgit.a. Meson already includes xdiff when it builds libgit.a, but Makefile does not. Rather than telling the Rust compiler to also link against xdiff/lib.a, if Makefile was used as opposed to Meson, seemed like a clunkier solution.

I should have asked for a better way to accomplish this as part of my commit message or as a question on the mailing list.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.