Re: [PATCH v2 01/18] cleanup: rename variables that collide with Rust primitive type names
- From
Ezekiel Newren <ezekielnewren@gmail.com>
- Date
- Sep 19, 2025, 19:36 UTC
- Message-ID
- <CAH=ZcbDn0tEPu-xuY4uOMk1uajT_Wma=9G5mQ3PBsC-mQm1EqQ@mail.gmail.com>
- In-Reply-To
- <xmqqa52tgne2.fsf@gitster.g>
On Wed, Sep 17, 2025 at 8:32 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Isn't the true cause of the trouble the (I might say "misguided") > desire to use "u16" as a type in C code? As long as we all agree > that the data that can be passed across the ffi barrier should be of > the types of known size, and let C side use uint(8|16|32|64)_t and > Rust side use u(8|16|32|64) consistently, we do not need to have > this "cleanup", do we?
It appears that I am the only one in favor of using Rust type names in C. Going forward I'll use [ui]int(8|16|32|64)_t types going forward. I'll drop this commit.