Re: [PATCH v2 00/18] Introduce rust: In xdiff

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 22, 2025, 15:31 UTC
Message-ID: <CAH=ZcbCZXavx52521cFHdXZn=BCWBiR1aG10ekZVg3PVVJb2VA@mail.gmail.com>
In-Reply-To: <aNFIozagGc0MoseL@pks.im>

On Mon, Sep 22, 2025 at 7:01 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 5 quoted lines

> I don't think there'd have to be major changes to the current version
> of my patch series. The idea of that patch series is very much getting
> buy-in regarding our roadmap and focus less on the actual build infra.
> So the changes introduced are mostly an MVC, and I very much think that
> we'll have to iterate quite a bit on it, but that's intended.

So long as you're flexible with the build infra details then I'm ok with rebasing on your work.

What does MVC stand for?

> I think that a lot of the steps you outline below are logical next steps
> to get there. If I can change anything to make these next steps easier
> for you I'm happy to do so. But I also don't think it's too bad if we
> have to change the current infra quite significantly to get there.

I think we can discuss those code and infra changes in a later patch series.

Show 6 quoted lines

> > I wanted feedback on:
> >   * Cleaning up Rust type name collisions
> >     * People don't like it, so I'll drop that
>
> I don't have a strong opinion on this. If it creates issues I personally
> don't mind fixing it.

Junio doesn't like it, so I'm not going to do it.

Show 9 quoted lines

> >   * Have Makefile produce libgit.a correctly.
> >     * I think this is a good idea, but it doesn't belong in this patch series.
> >   * Adding Rust unit test which required fixing Make and adding
> > build-helper to reduce boilerplate code
> >     * I think this is a good idea, but should be added later.
> >   * Introduce cbindgen to avoid desync errors between Rust and C.
> >     * LIke other points above; This should be added later.
>
> Agreed, these all make sense to me.

I think the changes to Makefile to build ligbit.a correctly can be an orthogonal patch series. The rest can come later.

Show 5 quoted lines

> >   * What should we call the crate that will be the new home for .c and
> > .h files in the root of Git?
>
> We could call this something like "libgit-ffi", but I don't care too
> much.

I prefer Eric Sunshine's suggestion of gitcore, no hyphen.