Re: [PATCH v2 02/18] make: add -fPIE flag
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 17, 2025, 07:44 UTC
- Message-ID
- <CAPig+cRGtMX9bQhb+7g5aXRVjpLKY-qDdQP95f9TmbY8j_BweQ@mail.gmail.com>
- In-Reply-To
- <7082e32c5975d2aaa277eddae7497eba0f2131e0.1758071798.git.gitgitgadget@gmail.com>
On Tue, Sep 16, 2025 at 9:17 PM Ezekiel Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 10 quoted lines
> make: add -fPIE flag > > Signed-off-by: Ezekiel Newren <ezekielnewren@gmail.com> > --- > diff --git a/Makefile b/Makefile > @@ -1402,7 +1402,7 @@ endif > CC_LD_DYNPATH = -Wl,-rpath, > -BASIC_CFLAGS = -I. > +BASIC_CFLAGS = -I. -fPIE > BASIC_LDFLAGS =
The commit message explains what the patch is doing (which is obvious from the patch itself) but doesn't explain why this change is needed, hence it is very difficult for a reviewer to understand why such a change is necessary.