Re: [PATCH v2 04/18] make: merge reftable lib into libgit.a

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 19, 2025, 20:00 UTC
Message-ID: <CAH=ZcbCRzGGR1RFTWV1Zo7bm+DScx=zOJ=Ov-WkaQNrDN9w1Nw@mail.gmail.com>
In-Reply-To: <xmqq348i5kqx.fsf@gitster.g>

On Fri, Sep 19, 2025 at 1:02 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 23 quoted lines

> Aside from the comment already given about the fact that the
> proposed log message does not explain any reason why these change
> are necessary, this step and the previous step are fairly hostile to
> merging the topic to play well with other topics, especially given
> that there would be topics in flight that may want to add, remove,
> or reorder these two existing lists.
>
> I wonder if these could have been arranged like the following instead?
>
>  * Drop "REFTABLE_LIB = reftable/libreftable.a" and the target that
>    runs "ar" to mantain that archive.
>
>  * Leave "REFTABLE_OBJS += $objects.o" lines alone.
>
>  * Add them into LIB_OBJS so that they are included in libgit.a,
>    perhaps a single line like this:
>
>         LIB_OBJS += $(REFTABLE_OBJS)
>
> Wouldn't that have worked equally well for the (unstated) purpose of
> these two patches without incurring unnecessary risk of mismerges?
>
> Similar arrangement for xdiff.

Like the previous two commits; This one continues the effort to get the Rust compiler to link against libgit.a. Meson already includes the reftable in its libgit.a, but Makefile does not.

The reason why I was trying to get the Rust compiler to link against libgit.a is because I wanted to get Rusts unit testing to work. If the Rust code calls a C function from Git then 'cargo test' needs to know about it.

However I think I'll drop these 3 commits since 'cargo test' doesn't need to be part of the introduction of Rust. It would be nice for make to be able to run Rust unit tests at some point though.