Re: [PATCH v2 00/18] Introduce rust: In xdiff
- From
Ezekiel Newren <ezekielnewren@gmail.com>
- Date
- Sep 22, 2025, 15:18 UTC
- Message-ID
- <CAH=ZcbDkDfc6j_gQCt_q9RLP_ozYqr09i1-xe2mvhSQRgf8MGg@mail.gmail.com>
- In-Reply-To
- <aNFIwFD6E6Lngy5M@pks.im>
On Mon, Sep 22, 2025 at 7:01 AM Patrick Steinhardt <ps@pks.im> wrote:
> I personally think either (A) or (B) would be good choices. I would > slightly lean towards (B) just so that we have something that we can > already play around with while building the next steps.
I'm fine with B if you fix the wording in your Breaking Changes about Rust being introduced in version 2.52. Rust was introduced to Git in 2.49.
Elijah points this out in 1 and 2: [1] https://lore.kernel.org/git/CABPp-BFXRbaHk9U3BX+d12bZ+ryGOp+btR0ODMw+HtD7xd+MBQ@mail.gmail.com/ [2] https://lore.kernel.org/git/CABPp-BEiK49f_UB5UPe3qM9O7vQGGFJ8Nshw1f6W_6Lw7HRL6Q@mail.gmail.com/
> By the way: I'm also happy to change attribution of some of the patches > in my patch series to mention Ezekiel as author. I don't care much who > is listed for the initial patches that introduce Rust, but would retain > my own authorship for the "varint" and "BreakingChanges" commits.
My only other concern is with varint. You use usize on the Rust side and then uint64_t on the C side, but I'm ok with fixing that later as it only breaks 'linux32 (i386/ubuntu:focal)' in the github workflows.