Re: [PATCH v2 02/18] make: add -fPIE flag

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 19, 2025, 19:48 UTC
Message-ID: <CAH=ZcbAOBnEVfyNy_4hdpe_dvsqDxsKVTcvurJz_iUWiqOzG3g@mail.gmail.com>
In-Reply-To: <CAPig+cRGtMX9bQhb+7g5aXRVjpLKY-qDdQP95f9TmbY8j_BweQ@mail.gmail.com>

On Wed, Sep 17, 2025 at 1:45 AM Eric Sunshine <sunshine@sunshineco.com> wrote:

> The commit message explains what the patch is doing (which is obvious
> from the patch itself) but doesn't explain why this change is needed,
> hence it is very difficult for a reviewer to understand why such a
> change is necessary.

I was trying to get the rust compiler to link against libgit.a. Both Meson and Makefile produce libgit.a. No changes were to meson.build were necessary for that to work, but but with Makefile I would get errors like: relocation R_X86_64_32 against `.rodata' can not be used when making a PIE object; recompile with -fPIE ...

I should have added this to the commit message.