Re: [PATCH] pack-write: skip .rev work when not writing .rev

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 8, 2021, 03:50 UTC
Message-ID: <YTgy85aiCL1bJjKE@nand.local>
In-Reply-To: <YTglEreI7nFCII/b@nand.local>

On Tue, Sep 07, 2021 at 10:50:58PM -0400, Taylor Blau wrote:

> Of the two, I think the former is more appealing (since no other
> functions called by finish_tmp_packfile() are guarded like that; they
> conditionally behave as noops depending on `flags`).

Sorry; this is nonsensical. The only other function we call is write_idx_file() which merely changes its behavior based on flags, but it never behaves as a noop.

That doesn't change my thinking about preferring the former of my two suggestions, but just wanted to correct my error.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.

Re: [PATCH] pack-write: skip *.rev work when not writing *.rev

Re: [PATCH] pack-write: skip .rev work when not writing .rev