Re: [PATCH 4/5] commit-graph: refactor dispatch loop for style

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 15, 2021, 18:53 UTC
Message-ID: <YCrDGhIq7kU57p1s@nand.local>
In-Reply-To: <20210215184118.11306-5-avarab@gmail.com>

On Mon, Feb 15, 2021 at 07:41:17PM +0100, Ævar Arnfjörð Bjarmason wrote:

> I think it's more readable to have one if/elsif/else chain here than
> the code this replaces.

FWIW, I find the pre-image more readable than what you are proposing replacing it with here.

Of course, I have no doubts about the obvious correctness of this patch; I'm merely suggesting that I wouldn't be sad to see us apply the first three patches, and the fifth patch, but drop this one.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.