Re: [PATCH v2 2/4] builtin/multi-pack-index.c: don't handle 'progress' separately
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Feb 16, 2021, 11:47 UTC
- Message-ID
- <030f1d2f-62eb-03c0-b23e-d491fac50463@gmail.com>
- In-Reply-To
- <YCrrauGOiVkpM2fP@nand.local>
On 2/15/2021 4:45 PM, Taylor Blau wrote:
Show 11 quoted lines
> On Mon, Feb 15, 2021 at 10:39:16PM +0100, Ævar Arnfjörð Bjarmason wrote: >> Funnily enough we could also just do: >> >> opts.flags = isatty(2); >> >> Since there's a grand total of one flag it knows about, and >> MIDX_PROGRESS is defined as 1. > > :-). I have a handful of branches that add some new flags (including the > original series I sent down-thread), so I'm not sure that I'm in favor > of this (admittedly cute) hack.
It's also _wrong_ if the user passes in '--progress' but redirects stderr to a file. I don't know why someone would want to do that, but they could, and we honor that throughout all commands.
Thanks, -Stolee