git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/9] Documentation/technical: describe multi-pack reverse indexes

From
Derrick Stolee <stolee@gmail.com>
Date
Feb 11, 2021, 02:48 UTC
Message-ID
<320ef364-05ac-7d51-a6f9-770d32590766@gmail.com>
In-Reply-To
<e64504bad6e181522946a8f234e12f569bede89e.1612998106.git.me@ttaylorr.com>
On 2/10/21 6:03 PM, Taylor Blau wrote:> +Instead of mapping between offset, pack-, and index position, this

The "pack-," should be paired with "index-position" or drop the hyphen in both cases. Perhaps just be explicit, especially since "position" doesn't match with "offset":

  Instead  of mapping between pack offset, pack position, and index
  position, ...
> +reverse index maps between an object's position within the midx, and
> +that object's position within a pseudo-pack that the midx describes.
nit: use multi-pack-index or MIDX, not lower-case 'midx'.
Show 8 quoted lines
> +Crucially, the objects' positions within this pseudo-pack are the same
> +as their bit positions in a multi-pack reachability bitmap.
> +
> +As a motivating example, consider the multi-pack reachability bitmap
> +(which does not yet exist, but is what we are building towards here). We
> +need each bit to correspond to an object covered by the midx, and we
> +need to be able to convert bit positions back to index positions (from
> +which we can get the oid, etc).

These paragraphs are awkward. Instead of operating in the hypothetical world of reachability bitmaps, focus on the fact that bitmaps need a bidirectional mapping between "bit position" and an object ID.

Here is an attempt to reword some of the context you are using here. Feel free to take as much or as little as you want.

  The multi-pack-index stores the object IDs in lexicographical order
  (lex-order) to allow binary search. To allow compressible reachability
  bitmaps to pair with a multi-pack-index, a different ordering is
  required. When paired with a single packfile, the order used is the
  object order within the packfile (called the pack-order). Construct
  a "pseudo-pack" by concatenating all tracked packfiles in the
  multi-pack-index. We now need a mapping between the lex-order and the
  pseudo-pack-order.
Show 65 quoted lines
> +One solution is to let each bit position in the index correspond to
> +the same position in the oid-sorted index stored by the midx. But
> +because oids are effectively random, there resulting reachability
> +bitmaps would have no locality, and thus compress poorly. (This is the
> +reason that single-pack bitmaps use the pack ordering, and not the .idx
> +ordering, for the same purpose.)
> +
> +So we'd like to define an ordering for the whole midx based around
> +pack ordering. We can think of it as a pseudo-pack created by the
> +concatenation of all of the packs in the midx. E.g., if we had a midx
> +with three packs (a, b, c), with 10, 15, and 20 objects respectively, we
> +can imagine an ordering of the objects like:
> +
> +    |a,0|a,1|...|a,9|b,0|b,1|...|b,14|c,0|c,1|...|c,19|
> +
> +where the ordering of the packs is defined by the midx's pack list,
> +and then the ordering of objects within each pack is the same as the
> +order in the actual packfile.
> +
> +Given the list of packs and their counts of objects, you can
> +na&iuml;vely reconstruct that pseudo-pack ordering (e.g., the object at
> +position 27 must be (c,1) because packs "a" and "b" consumed 25 of the
> +slots). But there's a catch. Objects may be duplicated between packs, in
> +which case the midx only stores one pointer to the object (and thus we'd
> +want only one slot in the bitmap).
> +
> +Callers could handle duplicates themselves by reading objects in order
> +of their bit-position, but that's linear in the number of objects, and
> +much too expensive for ordinary bitmap lookups. Building a reverse index
> +solves this, since it is the logical inverse of the index, and that
> +index has already removed duplicates. But, building a reverse index on
> +the fly can be expensive. Since we already have an on-disk format for
> +pack-based reverse indexes, let's reuse it for the midx's pseudo-pack,
> +too.
> +
> +Objects from the midx are ordered as follows to string together the
> +pseudo-pack. Let _pack(o)_ return the pack from which _o_ was selected
> +by the midx, and define an ordering of packs based on their numeric ID
> +(as stored by the midx). Let _offset(o)_ return the object offset of _o_
> +within _pack(o)_. Then, compare _o~1~_ and _o~2~_ as follows:
> +
> +  - If one of _pack(o~1~)_ and _pack(o~2~)_ is preferred and the other
> +    is not, then the preferred one sorts first.
> ++
> +(This is a detail that allows the midx bitmap to determine which
> +pack should be used by the pack-reuse mechanism, since it can ask
> +the midx for the pack containing the object at bit position 0).
> +
> +  - If _pack(o~1~) &ne; pack(o~2~)_, then sort the two objects in
> +    descending order based on the pack ID.
> +
> +  - Otherwise, _pack(o~1~) &equals; pack(o~2~)_, and the objects are
> +    sorted in pack-order (i.e., _o~1~_ sorts ahead of _o~2~_ exactly
> +    when _offset(o~1~) &lt; offset(o~2~)_).
> +
> +In short, a midx's pseudo-pack is the de-duplicated concatenation of
> +objects in packs stored by the midx, laid out in pack order, and the
> +packs arranged in midx order (with the preferred pack coming first).
> +
> +Finally, note that the midx's reverse index is not stored as a chunk in
> +the multi-pack-index itself. This is done because the reverse index
> +includes the checksum of the pack or midx to which it belongs, which
> +makes it impossible to write in the midx. To avoid races when rewriting
> +the midx, a midx reverse index includes the midx's checksum in its
> +filename (e.g., `multi-pack-index-xyz.rev`).

The rest of these details make sense and sufficiently motivate the ordering, once the concept is clear.

Thanks, -Stolee

Previous: Taylor BlauNext: Taylor Blau
Message 53 of 171 in “midx: implement a multi-pack reverse index”
  1. 0/9 midx: implement a multi-pack reverse indexTaylor Blau, Feb 10, 2021
  2. 1/9 t/helper/test-read-midx.c: add '--show-objects'Taylor Blau, Feb 10, 2021
  3. Derrick StoleeFeb 11, 2021
  4. Taylor BlauFeb 11, 2021
  5. 2/9 midx: allow marking a pack as preferredTaylor Blau, Feb 10, 2021
  6. SZEDER GáborFeb 11, 2021
  7. Taylor BlauFeb 15, 2021
  8. Ævar Arnfjörð BjarmasonFeb 15, 2021
  9. 0/5 commit-graph: parse_options() cleanupÆvar Arnfjörð Bjarmason, Feb 15, 2021
  10. 1/5 commit-graph: define common usage with a macroÆvar Arnfjörð Bjarmason, Feb 15, 2021
  11. Derrick StoleeFeb 16, 2021
  12. 2/5 commit-graph: remove redundant handling of -hÆvar Arnfjörð Bjarmason, Feb 15, 2021
  13. Derrick StoleeFeb 16, 2021
  14. 4/5 commit-graph: refactor dispatch loop for styleÆvar Arnfjörð Bjarmason, Feb 15, 2021
  15. Taylor BlauFeb 15, 2021
  16. Derrick StoleeFeb 16, 2021
  17. Ævar Arnfjörð BjarmasonFeb 16, 2021
  18. Derrick StoleeFeb 16, 2021
  19. 3/5 commit-graph: use parse_options_concat()Ævar Arnfjörð Bjarmason, Feb 15, 2021
  20. Taylor BlauFeb 15, 2021
  21. Taylor BlauFeb 15, 2021
  22. Ævar Arnfjörð BjarmasonFeb 15, 2021
  23. SZEDER GáborSep 17, 2021
  24. Jeff KingSep 17, 2021
  25. Taylor BlauSep 18, 2021
  26. Ævar Arnfjörð BjarmasonSep 18, 2021
  27. Taylor BlauSep 18, 2021
  28. Taylor BlauSep 18, 2021
  29. Ævar Arnfjörð BjarmasonSep 18, 2021
  30. 5/5 commit-graph: show usage on "commit-graph [write|verify] garbage"Ævar Arnfjörð Bjarmason, Feb 15, 2021
  31. Taylor BlauFeb 15, 2021
  32. Derrick StoleeFeb 16, 2021
  33. 0/4 midx: split out sub-commandsTaylor Blau, Feb 15, 2021
  34. 1/4 builtin/multi-pack-index.c: inline 'flags' with optionsTaylor Blau, Feb 15, 2021
  35. 2/4 builtin/multi-pack-index.c: don't handle 'progress' separatelyTaylor Blau, Feb 15, 2021
  36. Ævar Arnfjörð BjarmasonFeb 15, 2021
  37. Taylor BlauFeb 15, 2021
  38. Derrick StoleeFeb 16, 2021
  39. 3/4 builtin/multi-pack-index.c: define common usage with a macroTaylor Blau, Feb 15, 2021
  40. 4/4 builtin/multi-pack-index.c: split sub-commandsTaylor Blau, Feb 15, 2021
  41. Ævar Arnfjörð BjarmasonFeb 15, 2021
  42. Taylor BlauFeb 15, 2021
  43. Ævar Arnfjörð BjarmasonFeb 15, 2021
  44. Taylor BlauFeb 15, 2021
  45. Derrick StoleeFeb 16, 2021
  46. Taylor BlauFeb 16, 2021
  47. 3/9 midx: don't free midx_name earlyTaylor Blau, Feb 10, 2021
  48. 4/9 midx: keep track of the checksumTaylor Blau, Feb 10, 2021
  49. Derrick StoleeFeb 11, 2021
  50. Taylor BlauFeb 11, 2021
  51. 5/9 midx: make some functions non-staticTaylor Blau, Feb 10, 2021
  52. 6/9 Documentation/technical: describe multi-pack reverse indexesTaylor Blau, Feb 10, 2021
  53. Derrick StoleeFeb 11, 2021
  54. Taylor BlauFeb 11, 2021
  55. 7/9 pack-revindex: read multi-pack reverse indexesTaylor Blau, Feb 10, 2021
  56. Derrick StoleeFeb 11, 2021
  57. Taylor BlauFeb 11, 2021
  58. Junio C HamanoFeb 11, 2021
  59. Taylor BlauFeb 11, 2021
  60. 8/9 pack-write.c: extract 'write_rev_file_order'Taylor Blau, Feb 10, 2021
  61. 9/9 pack-revindex: write multi-pack reverse indexesTaylor Blau, Feb 10, 2021
  62. Derrick StoleeFeb 11, 2021
  63. Taylor BlauFeb 11, 2021
  64. Junio C HamanoFeb 11, 2021
  65. Derrick StoleeFeb 11, 2021
  66. Junio C HamanoFeb 11, 2021
  67. 00/15 midx: implement a multi-pack reverse indexTaylor Blau, Feb 24, 2021
  68. 01/15 builtin/multi-pack-index.c: inline 'flags' with optionsTaylor Blau, Feb 24, 2021
  69. 03/15 builtin/multi-pack-index.c: define common usage with a macroTaylor Blau, Feb 24, 2021
  70. 02/15 builtin/multi-pack-index.c: don't handle 'progress' separatelyTaylor Blau, Feb 24, 2021
  71. 04/15 builtin/multi-pack-index.c: split sub-commandsTaylor Blau, Feb 24, 2021
  72. Jonathan TanMar 2, 2021
  73. Taylor BlauMar 2, 2021
  74. Jonathan TanMar 4, 2021
  75. Taylor BlauMar 4, 2021
  76. 06/15 builtin/multi-pack-index.c: display usage on unrecognized commandTaylor Blau, Feb 24, 2021
  77. 05/15 builtin/multi-pack-index.c: don't enter bogus cmd_modeTaylor Blau, Feb 24, 2021
  78. 07/15 t/helper/test-read-midx.c: add '--show-objects'Taylor Blau, Feb 24, 2021
  79. 08/15 midx: allow marking a pack as preferredTaylor Blau, Feb 24, 2021
  80. Jonathan TanMar 2, 2021
  81. Taylor BlauMar 2, 2021
  82. Jonathan TanMar 4, 2021
  83. Taylor BlauMar 4, 2021
  84. 15/15 pack-revindex: write multi-pack reverse indexesTaylor Blau, Feb 24, 2021
  85. Jonathan TanMar 2, 2021
  86. Taylor BlauMar 3, 2021
  87. Jonathan TanMar 4, 2021
  88. Taylor BlauMar 4, 2021
  89. 09/15 midx: don't free midx_name earlyTaylor Blau, Feb 24, 2021
  90. 11/15 midx: make some functions non-staticTaylor Blau, Feb 24, 2021
  91. 10/15 midx: keep track of the checksumTaylor Blau, Feb 24, 2021
  92. 12/15 Documentation/technical: describe multi-pack reverse indexesTaylor Blau, Feb 24, 2021
  93. Jonathan TanMar 2, 2021
  94. Taylor BlauMar 2, 2021
  95. Taylor BlauMar 2, 2021
  96. Jonathan TanMar 4, 2021
  97. 13/15 pack-revindex: read multi-pack reverse indexesTaylor Blau, Feb 24, 2021
  98. Jonathan TanMar 2, 2021
  99. Taylor BlauMar 3, 2021
  100. 14/15 pack-write.c: extract 'write_rev_file_order'Taylor Blau, Feb 24, 2021
  101. 00/16 midx: implement a multi-pack reverse indexTaylor Blau, Mar 11, 2021
  102. 02/16 builtin/multi-pack-index.c: don't handle 'progress' separatelyTaylor Blau, Mar 11, 2021
  103. Jeff KingMar 29, 2021
  104. 01/16 builtin/multi-pack-index.c: inline 'flags' with optionsTaylor Blau, Mar 11, 2021
  105. Jeff KingMar 29, 2021
  106. 03/16 builtin/multi-pack-index.c: define common usage with a macroTaylor Blau, Mar 11, 2021
  107. 04/16 builtin/multi-pack-index.c: split sub-commandsTaylor Blau, Mar 11, 2021
  108. Jeff KingMar 29, 2021
  109. Taylor BlauMar 29, 2021
  110. Jeff KingMar 30, 2021
  111. 05/16 builtin/multi-pack-index.c: don't enter bogus cmd_modeTaylor Blau, Mar 11, 2021
  112. 09/16 midx: don't free midx_name earlyTaylor Blau, Mar 11, 2021
  113. 07/16 t/helper/test-read-midx.c: add '--show-objects'Taylor Blau, Mar 11, 2021
  114. 06/16 builtin/multi-pack-index.c: display usage on unrecognized commandTaylor Blau, Mar 11, 2021
  115. Jeff KingMar 29, 2021
  116. Taylor BlauMar 29, 2021
  117. 08/16 midx: allow marking a pack as preferredTaylor Blau, Mar 11, 2021
  118. Jeff KingMar 29, 2021
  119. Taylor BlauMar 29, 2021
  120. Jeff KingMar 30, 2021
  121. 10/16 midx: keep track of the checksumTaylor Blau, Mar 11, 2021
  122. 11/16 midx: make some functions non-staticTaylor Blau, Mar 11, 2021
  123. 12/16 Documentation/technical: describe multi-pack reverse indexesTaylor Blau, Mar 11, 2021
  124. Jeff KingMar 29, 2021
  125. Taylor BlauMar 29, 2021
  126. 13/16 pack-revindex: read multi-pack reverse indexesTaylor Blau, Mar 11, 2021
  127. Jeff KingMar 29, 2021
  128. Taylor BlauMar 29, 2021
  129. 14/16 pack-write.c: extract 'write_rev_file_order'Taylor Blau, Mar 11, 2021
  130. 15/16 pack-revindex: write multi-pack reverse indexesTaylor Blau, Mar 11, 2021
  131. Jeff KingMar 29, 2021
  132. Taylor BlauMar 29, 2021
  133. 16/16 midx.c: improve cache locality in midx_pack_order_cmp()Taylor Blau, Mar 11, 2021
  134. Jeff KingMar 29, 2021
  135. Taylor BlauMar 29, 2021
  136. Jeff KingMar 30, 2021
  137. Derrick StoleeMar 12, 2021
  138. Jeff KingMar 29, 2021
  139. Junio C HamanoMar 29, 2021
  140. Taylor BlauMar 29, 2021
  141. Jeff KingMar 30, 2021
  142. Taylor BlauMar 30, 2021
  143. 00/16 midx: implement a multi-pack reverse indexTaylor Blau, Mar 30, 2021
  144. 01/16 builtin/multi-pack-index.c: inline 'flags' with optionsTaylor Blau, Mar 30, 2021
  145. 02/16 builtin/multi-pack-index.c: don't handle 'progress' separatelyTaylor Blau, Mar 30, 2021
  146. 04/16 builtin/multi-pack-index.c: split sub-commandsTaylor Blau, Mar 30, 2021
  147. 03/16 builtin/multi-pack-index.c: define common usage with a macroTaylor Blau, Mar 30, 2021
  148. 06/16 builtin/multi-pack-index.c: display usage on unrecognized commandTaylor Blau, Mar 30, 2021
  149. 05/16 builtin/multi-pack-index.c: don't enter bogus cmd_modeTaylor Blau, Mar 30, 2021
  150. 07/16 t/helper/test-read-midx.c: add '--show-objects'Taylor Blau, Mar 30, 2021
  151. 08/16 midx: allow marking a pack as preferredTaylor Blau, Mar 30, 2021
  152. Taylor BlauApr 1, 2021
  153. 10/16 midx: keep track of the checksumTaylor Blau, Mar 30, 2021
  154. 09/16 midx: don't free midx_name earlyTaylor Blau, Mar 30, 2021
  155. 11/16 midx: make some functions non-staticTaylor Blau, Mar 30, 2021
  156. 14/16 pack-write.c: extract 'write_rev_file_order'Taylor Blau, Mar 30, 2021
  157. pack-write: skip *.rev work when not writing *.revÆvar Arnfjörð Bjarmason, Sep 8, 2021
  158. Carlo ArenasSep 8, 2021
  159. Taylor BlauSep 8, 2021
  160. Junio C HamanoSep 8, 2021
  161. Taylor BlauSep 8, 2021
  162. Taylor BlauSep 8, 2021
  163. Ævar Arnfjörð BjarmasonSep 8, 2021
  164. Taylor BlauSep 8, 2021
  165. 12/16 Documentation/technical: describe multi-pack reverse indexesTaylor Blau, Mar 30, 2021
  166. 13/16 pack-revindex: read multi-pack reverse indexesTaylor Blau, Mar 30, 2021
  167. 16/16 midx.c: improve cache locality in midx_pack_order_cmp()Taylor Blau, Mar 30, 2021
  168. 15/16 pack-revindex: write multi-pack reverse indexesTaylor Blau, Mar 30, 2021
  169. Jeff KingMar 30, 2021
  170. Taylor BlauMar 30, 2021
  171. Jeff KingMar 30, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.