Re: [PATCH v4 00/16] midx: implement a multi-pack reverse index
- From
Jeff King <peff@peff.net>
- Date
- Mar 30, 2021, 16:01 UTC
- Message-ID
- <YGNLcBH5rldiSAWC@coredump.intra.peff.net>
- In-Reply-To
- <YGNIp4AHcdaHHHUc@nand.local>
On Tue, Mar 30, 2021 at 11:49:59AM -0400, Taylor Blau wrote:
Show 11 quoted lines
> On Tue, Mar 30, 2021 at 11:45:19AM -0400, Jeff King wrote: > > > This reroll differs only in the feedback I incorporated from Peff's review. They > > > are mostly cosmetic; the most substantial change being that the --preferred-pack > > > code now uses bsearch() to locate the name of the preferred pack (instead of > > > implementing a binary search itself). > > > > Yeah, I read over this part carefully, since it's actual new code (that > > isn't run yet!), but I think it is correct. > > Thankfully this does have coverage via any test that passes > `--preferred-pack` (like the one below).
Oh right, I forgot this was touching that early part. So now I'm doubly confident in it.
-Peff