Re: [PATCH 1/9] t/helper/test-read-midx.c: add '--show-objects'

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 11, 2021, 02:34 UTC
Message-ID: <YCSXp+YgDVCLL67Q@nand.local>
In-Reply-To: <7b422082-d6a9-5e64-17a0-559da7777a08@gmail.com>

On Wed, Feb 10, 2021 at 09:27:29PM -0500, Derrick Stolee wrote:

Show 24 quoted lines

> On 2/10/21 6:02 PM, Taylor Blau wrote:
> > +	if (show_objects) {
> > +		struct object_id oid;
> > +		struct pack_entry e;
> > +
> > +		for (i = 0; i < m->num_objects; i++) {
> > +			nth_midxed_object_oid(&oid, m, i);
> > +			fill_midx_entry(the_repository, &oid, &e, m);
> > +
> > +			printf("%s %"PRIu64"\t%s\n",
> > +			       oid_to_hex(&oid), e.offset, e.p->pack_name);
> > +		}
> > +		return 0;
> > +	}
> > +
> >  	printf("header: %08x %d %d %d %d\n",
> >  	       m->signature,
> >  	       m->version,
>
> It seems a little odd to me that the list of objects happens after
> the header information. Probably doesn't matter in your test cases,
> but I sometimes use the test helpers to diagnose data during development
> and could see piping this output into 'less' and wanting the header
> at the top.

Indeed. In theory you could pipe to tail instead (or to less and immediately hit 'G'), but I can't think of a good reason that this would have appeared above the header when I originally wrote the patch.

Anyway, it doesn't seem that the tests care about where this is (they're just looking for for a line that begins with the object id and ends with its offset), so I think this could probably be moved without thinking too hard about it.

> Thanks,
> -Stolee

Thanks, Taylor