git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] Introduce optional "keywords" on tag objects

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 10, 2007, 18:42 UTC
Message-ID
<Pine.LNX.4.64.0706101937250.4059@racer.site>
In-Reply-To
<200706101350.00271.johan@herland.net>
Hi,
On Sun, 10 Jun 2007, Johan Herland wrote:
> +	/* Verify the keywords: disallow ctrl chars, spaces and double commas */

What about Junio's suggestion, making it really strict at first, and only loosening it if we need to? IIRC it was alnum + '_', maybe even '-'.

Other than that, looks good to me. I trust that the test cases are exhaustive enough to support the patch from the practical side.

BTW this patch is exactly what I meant by conceptually closed. Thank you.

And please accept my apologies for my language. Reading some of it, I have to admit that it sounded as harsh as Junio suggested it to be. My only excuse is that I had an unplanned stay at the Paris airport for more than 9 hours (after a night in the plane where I could hardly sleep), so I should really have stayed away from writing emails. But since you addressed your emails to me, I wanted to reply to you as soon as I had the chance to.

Ciao, Dscho

Previous: Johan HerlandNext: Johan Herland
Message 28 of 90 in “error: char103: premature end of data”
  1. Johannes SchindelinJun 7, 2007
  2. Johan HerlandJun 7, 2007
  3. Johannes SchindelinJun 7, 2007
  4. Johan HerlandJun 7, 2007
  5. Johannes SchindelinJun 7, 2007
  6. Fix failed tag parsing when tag object has no body/message (and thus ends with a single '\n')Johan Herland, Jun 8, 2007
  7. Junio C HamanoJun 8, 2007
  8. Johan HerlandJun 8, 2007
  9. Junio C HamanoJun 8, 2007
  10. 0/21 Refactor the tag object (take 2)Johan Herland, Jun 9, 2007
  11. 01/21 Remove unnecessary code and comments on non-existing 8kB tag object restrictionJohan Herland, Jun 9, 2007
  12. 02/21 Return error messages when parsing fails.Johan Herland, Jun 9, 2007
  13. Junio C HamanoJun 9, 2007
  14. Johan HerlandJun 9, 2007
  15. Silence error messages unless 'thorough_verify' is setJohan Herland, Jun 9, 2007
  16. Johannes SchindelinJun 10, 2007
  17. Junio C HamanoJun 10, 2007
  18. Johannes SchindelinJun 10, 2007
  19. Johan HerlandJun 10, 2007
  20. Johannes SchindelinJun 10, 2007
  21. Johan HerlandJun 10, 2007
  22. 0/4 Restructure the tag objectJohan Herland, Jun 10, 2007
  23. 1/4 Make tag names (i.e. the tag object's "tag" line) optionalJohan Herland, Jun 10, 2007
  24. Junio C HamanoJun 10, 2007
  25. Johan HerlandJun 10, 2007
  26. Junio C HamanoJun 11, 2007
  27. 2/4 Introduce optional "keywords" on tag objectsJohan Herland, Jun 10, 2007
  28. Johannes SchindelinJun 10, 2007
  29. Johan HerlandJun 10, 2007
  30. Junio C HamanoJun 10, 2007
  31. Johan HerlandJun 10, 2007
  32. Junio C HamanoJun 11, 2007
  33. 3/4 Documentation/git-mktag: Document the changes in tag object structureJohan Herland, Jun 10, 2007
  34. 4/4 git-mktag tests: Expand on mktag selftests according to the new tag object structureJohan Herland, Jun 10, 2007
  35. Johannes SchindelinJun 10, 2007
  36. 03/21 Refactoring to make verify_tag() and parse_tag_buffer() more similarJohan Herland, Jun 9, 2007
  37. Johannes SchindelinJun 9, 2007
  38. Johan HerlandJun 9, 2007
  39. 04/21 Refactor verification of "tagger" line to be more similar to verification of "type" and "tagger" linesJohan Herland, Jun 9, 2007
  40. Junio C HamanoJun 9, 2007
  41. Johannes SchindelinJun 10, 2007
  42. 05/21 Make parse_tag_buffer_internal() handle item == NULLJohan Herland, Jun 9, 2007
  43. Junio C HamanoJun 9, 2007
  44. Move check for already parsed tag object to parse_tag_buffer() wrapper functionJohan Herland, Jun 10, 2007
  45. Johannes SchindelinJun 10, 2007
  46. 06/21 Refactor tag name verification loop to use index 'i' instead of incrementing pointer 'tag_line'Johan Herland, Jun 9, 2007
  47. Alex RiesenJun 9, 2007
  48. Johan HerlandJun 9, 2007
  49. Johannes SchindelinJun 10, 2007
  50. Johannes SchindelinJun 10, 2007
  51. 07/21 Copy the remaining differences from verify_tag() to parse_tag_buffer_internal()Johan Herland, Jun 9, 2007
  52. Alex RiesenJun 9, 2007
  53. Johan HerlandJun 9, 2007
  54. Johannes SchindelinJun 10, 2007
  55. 08/21 Switch from verify_tag() to parse_and_verify_tag_buffer() for verifying tag objects in git-mktagJohan Herland, Jun 9, 2007
  56. 09/21 Remove unneeded code from mktag.cJohan Herland, Jun 9, 2007
  57. Alex RiesenJun 9, 2007
  58. Johan HerlandJun 9, 2007
  59. 10/21 Free mktag's buffer before dyingJohan Herland, Jun 9, 2007
  60. Alex RiesenJun 9, 2007
  61. Johan HerlandJun 9, 2007
  62. Alex RiesenJun 9, 2007
  63. Johan HerlandJun 9, 2007
  64. Johannes SchindelinJun 10, 2007
  65. 11/21 Rewrite error messages; fix up line lengthsJohan Herland, Jun 9, 2007
  66. Johannes SchindelinJun 10, 2007
  67. 12/21 Use prefixcmp() instead of memcmp() for cleaner code with less magic numbersJohan Herland, Jun 9, 2007
  68. Alex RiesenJun 9, 2007
  69. Johan HerlandJun 9, 2007
  70. Johannes SchindelinJun 10, 2007
  71. 13/21 Collect skipping of header field names and calculation of line lengths in one placeJohan Herland, Jun 9, 2007
  72. Johannes SchindelinJun 10, 2007
  73. 14/21 Add proper parsing of "tagger" line, but only when thorough_verify is setJohan Herland, Jun 9, 2007
  74. Johannes SchindelinJun 10, 2007
  75. Johannes SchindelinJun 10, 2007
  76. 15/21 Make tag names (i.e. the tag object's "tag" line) optionalJohan Herland, Jun 9, 2007
  77. Johannes SchindelinJun 10, 2007
  78. 16/21 Introduce optional "keywords" on tag objectsJohan Herland, Jun 9, 2007
  79. Alex RiesenJun 9, 2007
  80. Johan HerlandJun 9, 2007
  81. Use xstrndup() instead of xmalloc() and memcpy(); fix buglet with generating default item->keywords.Johan Herland, Jun 9, 2007
  82. Junio C HamanoJun 10, 2007
  83. Fail if tag name and keywords is not within "printable ASCII"Johan Herland, Jun 10, 2007
  84. Junio C HamanoJun 10, 2007
  85. 17/21 Update comments on tag objects in mktag.cJohan Herland, Jun 9, 2007
  86. 18/21 git-fsck: Do thorough verification of tag objectsJohan Herland, Jun 9, 2007
  87. 19/21 Documentation/git-mktag: Document the changes in tag object structureJohan Herland, Jun 9, 2007
  88. 20/21 git-mktag tests: Expand on mktag selftests according to the new tag object structureJohan Herland, Jun 9, 2007
  89. 21/21 Add fsck_verify_ref_to_tag_object() to verify that refname matches name stored in tag objectJohan Herland, Jun 9, 2007
  90. Johannes SchindelinJun 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.