From: Johannes Schindelin Date: Sun, 10 Jun 2007 18:42:41 GMT Subject: Re: [PATCH 2/4] Introduce optional "keywords" on tag objects Message-ID: In-Reply-To: <200706101350.00271.johan@herland.net> Hi, On Sun, 10 Jun 2007, Johan Herland wrote: > + /* Verify the keywords: disallow ctrl chars, spaces and double commas */ What about Junio's suggestion, making it really strict at first, and only loosening it if we need to? IIRC it was alnum + '_', maybe even '-'. Other than that, looks good to me. I trust that the test cases are exhaustive enough to support the patch from the practical side. BTW this patch is exactly what I meant by conceptually closed. Thank you. And please accept my apologies for my language. Reading some of it, I have to admit that it sounded as harsh as Junio suggested it to be. My only excuse is that I had an unplanned stay at the Paris airport for more than 9 hours (after a night in the plane where I could hardly sleep), so I should really have stayed away from writing emails. But since you addressed your emails to me, I wanted to reply to you as soon as I had the chance to. Ciao, Dscho