Re: [PATCH 12/21] Use prefixcmp() instead of memcmp() for cleaner code with less magic numbers
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 10, 2007, 08:41 UTC
- Message-ID
- <Pine.LNX.4.64.0706100939460.4059@racer.site>
- In-Reply-To
- <200706090217.49818.johan@herland.net>
Hi,
On Sat, 9 Jun 2007, Johan Herland wrote:
> > - if (memcmp(data, "object ", 7)) > + if (prefixcmp(data, "object "))
FWIW I think that _these_ changes are actually somewhat worth it. And they should have come _instead_ of moving the order of the memcmp() around (you know which patch that was).
Ciao, Dscho