Re: [PATCH] Fix failed tag parsing when tag object has no body/message (and thus ends with a single '\n')

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2007, 16:06 UTC
Message-ID: <7vzm3aig7j.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200706081018.34207.johan@herland.net>

Johan Herland <johan@herland.net> writes:

Show 15 quoted lines

> I can:
>
> 1. Provide a new patch series to totally replace the previous 6-part patch 
> series (plus bugfixes). The new patch series will make smaller steps and 
> end up (hopefully) in a better place, with less overzealous 
> checking/parsing, and more "traditional" whitespacing.
>
> OR
>
> 2. Provide the babystep-series ending up exactly where we are today (i.e. 
> after the patch series, plus bug fixes). Then, provide patches on top of 
> the existing series to get it into shape, both scope-wise (i.e. not trying 
> to do too much) and whitespace-wise.
>
> Which do you prefer?

I am not sure if there is any practical difference between the two ;-). But in either case, it appears that we should first revert d9fa4a8 from 'next' and start from clean slate. It really seems that the patch series did upset too many people; personally I found the first patch still was follow-able, but I do agree that it should have been much smaller and not mixing too many things into one).

So, let's do 1.